core icon indicating copy to clipboard operation
core copied to clipboard

Catch exception in Bleak init as this is not fatal for esphome

Open ryanwinter opened this issue 3 years ago • 1 comments

Proposed change

Currently if Bleak throws an exception during init (it currently does if the platform is not supported), then the esphome component will fail to load. However this exception is not fatal and the esphome component can function without the bluetooth stack

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
    • fixes https://github.com/home-assistant/core/issues/77993
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

ryanwinter avatar Sep 20 '22 19:09 ryanwinter

Hey there @ottowinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

This is a change that does not apply to the platforms the Home Assistant project supports. In this case, it is for FreeBSD; however, the Home Assistant project doesn't support it.

Therefore, we should not add this change.

../Frenck

frenck avatar Sep 26 '22 09:09 frenck