core icon indicating copy to clipboard operation
core copied to clipboard

Add serial_number to device registry entries

Open emontnemery opened this issue 3 years ago • 2 comments

Proposed change

Add serial_number to device registry entries

The serial number can be displayed in the device card in frontend

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [ ] The code change is tested and works locally.
  • [ ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ ] There is no commented out code in this PR.
  • [ ] I have followed the development checklist
  • [ ] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

emontnemery avatar Sep 02 '22 12:09 emontnemery

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (config) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Related arch discussion

https://github.com/home-assistant/architecture/discussions/717

bdraco avatar Sep 02 '22 20:09 bdraco

We agreed this was OK. The related architecture discussion can be solved by frontend simply picking MAC(s) from the device entry and displaying that.

emontnemery avatar Sep 27 '22 07:09 emontnemery

The related architecture discussion can be solved by frontend simply picking MAC(s) from the device entry and displaying that.

I'm confused by this comment @emontnemery, so your are saying MAC addresses could be just picked up by the frontend from the identifiers...

Why isn't serial in the identifiers as well in that case?

That comment, just made this PR invalid IMHO.

frenck avatar Sep 27 '22 07:09 frenck