core icon indicating copy to clipboard operation
core copied to clipboard

Add switch platform to devolo_home_network

Open Shutgun opened this issue 3 years ago • 5 comments

Proposed change

Add the switch platform to devolo_home_network. This needs MR #71051 to pass the unittests.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/22886

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [x] 🏆 Platinum

To help with the load of incoming pull requests:

Shutgun avatar May 25 '22 16:05 Shutgun

Hey there @2fake, mind taking a look at this pull request as it has been labeled with an integration (devolo_home_network) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

Marked this PR as draft, as it depends on #71051

frenck avatar Jun 22 '22 22:06 frenck

Hi @frenck , could we then maybe merge #71051, as it was basically completely reviewed by @emontnemery ? He just didn't wan't to merge it back then because there was no consumer of the new code. The consumer is this MR here, but I'm fearing a deadlock, that #71051 is not merged because #72494 is draft and #72494 stays draft because #71051 is not merged ...

Shutgun avatar Jun 23 '22 06:06 Shutgun

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Sep 21 '22 06:09 github-actions[bot]

It's waiting for https://github.com/home-assistant/core/pull/71051 to be merged ...

Shutgun avatar Sep 21 '22 08:09 Shutgun

Kicking CI.

MartinHjelmare avatar Jan 09 '23 16:01 MartinHjelmare