core
core copied to clipboard
Support filtering state changes attributed to a service call (version 2)
Proposed change
Support filtering state changes attributed to a service call, to help avoid false positives in the logbook
This PR has the same goal as #72084, but the implementation is a little bit different.
The false positives are caused by any state change within a 5s window of firing off a service call being attributed to that service call.
As an example of a false positive, consider an automation "Morning lights" turning some lights on in the morning.
If the same light is turned off by something else at around the same time as the automation runs, the logbook will currently unhelpfully claim something like this:

This is really confusing, sending users off on a wild goose chase trying to understand why their "Wakeup lights" automation is turning lights off sometimes.
This PR has a proposal for how that could be achieved, with switch entity services as an example
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [ ] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [ ] The code change is tested and works locally.
- [ ] Local tests pass. Your PR cannot be merged unless tests pass
- [ ] There is no commented out code in this PR.
- [ ] I have followed the development checklist
- [ ] The code has been formatted using Black (
black --fast homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
The integration reached or maintains the following Integration Quality Scale:
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (switch) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)
I like this design a lot better. Some small comments above
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.