core icon indicating copy to clipboard operation
core copied to clipboard

Add broadlink climate platform

Open majuss opened this issue 3 years ago • 12 comments

Breaking change

Proposed change

Added climate platform for broadlink devices.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/15762

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [x] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

majuss avatar Dec 13 '21 12:12 majuss

Hey there @danielhiversen, @felipediel, @l-i-am, mind taking a look at this pull request as it has been labeled with an integration (broadlink) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

I think it's now the fifth try or something like that :D https://github.com/home-assistant/core/pull/45780

majuss avatar Dec 13 '21 12:12 majuss

Even if you only apply this to climate.py and not to the other platforms, I still think this would benefit from being migrated to attr format: https://developers.home-assistant.io/docs/core/entity/#entity-class-or-instance-attributes

You can see an example in #61605

epenet avatar Dec 13 '21 15:12 epenet

Even if you only apply this to climate.py and not to the other platforms, I still think this would benefit from being migrated to attr format: https://developers.home-assistant.io/docs/core/entity/#entity-class-or-instance-attributes

You can see an example in #61605

After 2 years of trying to get it in, I jsut would be glad if it was finally added :D I don't have that much time at my disposal.

majuss avatar Dec 22 '21 10:12 majuss

After 2 years of trying to get it in, I just would be glad if it was finally added :D I don't have that much time at my disposal.

Agree, let's get it in and then optimize.

Simone

chemelli74 avatar Dec 22 '21 19:12 chemelli74

There is a small conflict on the CODEOWNERS file. The format has changed slightly to now include the tests folder. Could you rebase and adjust accordingly?

epenet avatar Dec 22 '21 21:12 epenet

There is a small conflict on the CODEOWNERS file. The format has changed slightly to now include the tests folder. Could you rebase and adjust accordingly?

Can you please tell me exactly how to rebase correctly? Everytime I did it in the past everything went straight to hell.

majuss avatar Dec 23 '21 21:12 majuss

Can you please tell me exactly how to rebase correctly? Everytime I did it in the past everything went straight to hell.

Did you try following https://developers.home-assistant.io/docs/development_catching_up ?

Simone

chemelli74 avatar Dec 23 '21 21:12 chemelli74

I followed that guide, rebase was successful, but unable to push, -f and now I have the current situation ^^

majuss avatar Dec 23 '21 22:12 majuss

Hi there 👋

This PR seems to be stuck a bit. Can we get it unstuck? @majuss Could you rebase the PR onto the latest dev (and fix the conflicts during the rebase?). Would be awesome 👍

frenck avatar Jun 23 '22 00:06 frenck

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

github-actions[bot] avatar Oct 07 '22 20:10 github-actions[bot]

I will work on this PR in the next weeks.

majuss avatar Oct 18 '22 13:10 majuss

@majuss do you want some assistance with this PR? e.g. cleaning up the merge conflicts. I am using your custom_component and would be glad to help make this part of core.

eifinger avatar Nov 20 '22 12:11 eifinger

This PR seems stale so setting as draft.

gjohansson-ST avatar May 13 '23 10:05 gjohansson-ST