core
core copied to clipboard
Add Home Connect Washer Dryer
Proposed change
This PR adds support for WasherDryer appliances to the HomeConnect integration.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue:
- This PR is related to issue:
- Link to documentation pull request:
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] The code has been formatted using Black (
black --fast homeassistant tests) - [ ] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [ ] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [ ] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
The integration reached or maintains the following Integration Quality Scale:
- [ ] No score or internal
- [ ] 🥈 Silver
- [ ] 🥇 Gold
- [ ] 🏆 Platinum
To help with the load of incoming pull requests:
- [x] I have reviewed two other open pull requests in this repository.
Hey there @davidmstraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)
I made PR #63850 and #63851 to add the fridge and freezer because this PR has a breaking change.
Hey there!
Would love to see the integration for the WasherDryer making its way into home assistant! Could I help in any way making this PR move forwards?
@BraveChicken1 There is a merge conflict (caused by the separate PRs), could you take a look and see if we can move this PR forward? 👍
Hi @frenck! I'm gonna resolve the merge conflict! However, this PR is causing a breaking change for devices.
However, this PR is causing a breaking change for devices.
I see that needs to be resolved. Either add a migration for existing entities, or don't break it :)
This PR seems to be running stale. I'll go ahead and close it for now. Feel free to re-open when ready to work on it again.
../Frenck