core icon indicating copy to clipboard operation
core copied to clipboard

Add Home Connect Washer Dryer

Open BraveChicken1 opened this issue 4 years ago • 6 comments

Proposed change

This PR adds support for WasherDryer appliances to the HomeConnect integration.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [x] New feature (which adds functionality to an existing integration)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue:
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] The code has been formatted using Black (black --fast homeassistant tests)
  • [ ] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • [ ] No score or internal
  • [ ] 🥈 Silver
  • [ ] 🥇 Gold
  • [ ] 🏆 Platinum

To help with the load of incoming pull requests:

BraveChicken1 avatar Oct 23 '21 10:10 BraveChicken1

Hey there @davidmstraub, mind taking a look at this pull request as it has been labeled with an integration (home_connect) you are listed as a code owner for? Thanks! (message by CodeOwnersMention)

I made PR #63850 and #63851 to add the fridge and freezer because this PR has a breaking change.

BraveChicken1 avatar Jan 10 '22 19:01 BraveChicken1

Hey there!

Would love to see the integration for the WasherDryer making its way into home assistant! Could I help in any way making this PR move forwards?

jduthon avatar Mar 20 '22 14:03 jduthon

@BraveChicken1 There is a merge conflict (caused by the separate PRs), could you take a look and see if we can move this PR forward? 👍

frenck avatar Jun 22 '22 22:06 frenck

Hi @frenck! I'm gonna resolve the merge conflict! However, this PR is causing a breaking change for devices.

BraveChicken1 avatar Jun 23 '22 18:06 BraveChicken1

However, this PR is causing a breaking change for devices.

I see that needs to be resolved. Either add a migration for existing entities, or don't break it :)

frenck avatar Jun 23 '22 21:06 frenck

This PR seems to be running stale. I'll go ahead and close it for now. Feel free to re-open when ready to work on it again.

../Frenck

frenck avatar Jan 17 '23 14:01 frenck