core icon indicating copy to clipboard operation
core copied to clipboard

Fix problems with automatic management of Schlage locks

Open dknowles2 opened this issue 1 year ago • 1 comments

Proposed change

Fix a problem with auto-addition and removal of Schlage locks caused by comparing the wrong identifiers. The device_id we save in Schlage entities is from the Schlage API and is not the same as the Home Assistant concept of a device_id, so when we go to compare the previously seen locks with recently refreshed, we always replace all the existing entities. This causes the entities to completely refresh on every data reload and causes manual renames to get wiped out.

Type of change

  • [ ] Dependency upgrade
  • [x] Bugfix (non-breaking change which fixes an issue)
  • [ ] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #127455
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [ ] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [ ] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

dknowles2 avatar Oct 05 '24 23:10 dknowles2

#127479 is another related bug report that manifests in a different way

dknowles2 avatar Oct 05 '24 23:10 dknowles2