core icon indicating copy to clipboard operation
core copied to clipboard

Add Sky remote integration

Open dunnmj opened this issue 1 year ago • 4 comments
trafficstars

Proposed change

Adds the ability to send commands to a networked skyHD or skyq box.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

Link to library: https://pypi.org/project/skyboxremote/

Checklist

  • [x] The code change is tested and works locally.
  • [x] Local tests pass. Your PR cannot be merged unless tests pass
  • [x] There is no commented out code in this PR.
  • [x] I have followed the development checklist
  • [x] I have followed the perfect PR recommendations
  • [x] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [x] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • [x] Documentation added/updated for www.home-assistant.io https://github.com/dunnmj/home-assistant.io/tree/add-sky_remote-docs

If the code communicates with devices, web services, or third-party tools:

  • [x] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [x] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

  • [x] I have reviewed two other open pull requests in this repository. Co author @saty9 reviewed

dunnmj avatar Aug 23 '24 19:08 dunnmj

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Aug 23 '24 19:08 home-assistant[bot]

@joostlek Would you like all these commits squashed?

dunnmj avatar Sep 03 '24 22:09 dunnmj

@joostlek Would you like all these commits squashed?

No need to squash, it will be squashed on merge.

autinerd avatar Sep 07 '24 17:09 autinerd

Please also add a link to your library and to the documentation pull request in the PR description.

Added link to library Documentation PR already linked

dunnmj avatar Oct 08 '24 21:10 dunnmj

Also, the brands PR is missing

joostlek avatar Oct 25 '24 13:10 joostlek

What's the difference between sky_hub and this? Are they the same device?

joostlek avatar Oct 28 '24 15:10 joostlek

What's the difference between sky_hub and this? Are they the same device?

Both are from the company Sky. The Sky Hub is a broadband router, that integration allows presence info by looking at devices connected to it's wifi network.

This is a remote that allows control of Sky+HD and SkyQ satellite tv receivers over network.

As both are made by sky they use the same brand images.

dunnmj avatar Oct 30 '24 20:10 dunnmj

If both @dunnmj and @saty9 can send over their discord username (if you have one) that'd be great :)

joostlek avatar Nov 10 '24 13:11 joostlek

im also saty9 on discord

saty9 avatar Nov 10 '24 13:11 saty9

If both @dunnmj and @saty9 can send over their discord username (if you have one) that'd be great :)

Hi

I'm thew_mat on discord :)

dunnmj avatar Nov 10 '24 15:11 dunnmj