core icon indicating copy to clipboard operation
core copied to clipboard

Add Swidget integration

Open michaelkkehoe opened this issue 1 year ago • 4 comments

Breaking change

Proposed change

(follow-on from messing up https://github.com/home-assistant/core/pull/115613) This change introduces a new integration/ platform called 'Swidget' (https://www.swidget.com/collections/all-products). Swidget has plug and play inserts that can be inserted into host modules. This commit adds the integration and creates support for the 'light' entity. There will be additional changes coming for sensor/ binary_sensor/ button/ switch.

Type of change

  • [ ] Dependency upgrade
  • [ ] Bugfix (non-breaking change which fixes an issue)
  • [x] New integration (thank you!)
  • [ ] New feature (which adds functionality to an existing integration)
  • [ ] Deprecation (breaking change to happen in the future)
  • [ ] Breaking change (fix/feature causing existing functionality to break)
  • [ ] Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/32324

Checklist

  • [X] The code change is tested and works locally.
  • [X] Local tests pass. Your PR cannot be merged unless tests pass
  • [X] There is no commented out code in this PR.
  • [X] I have followed the development checklist
  • [X] I have followed the perfect PR recommendations
  • [X] The code has been formatted using Ruff (ruff format homeassistant tests)
  • [X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [X] The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [X] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [X] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [ ] Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

michaelkkehoe avatar Jun 25 '24 02:06 michaelkkehoe

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Jun 25 '24 02:06 home-assistant[bot]

Instead of marking it as ready for review, please read the message and fix the CLA issue. We can't review or merge the code if that is not fixed

joostlek avatar Oct 05 '24 20:10 joostlek

I have signed the CLA. When I try to sign it again, it tells me I've already signed it.

On Sat, Oct 5, 2024, 1:13 PM Joost Lekkerkerker @.***> wrote:

Instead of marking it as ready for review, please read the message and fix the CLA issue. We can't review or merge the code if that is not fixed

— Reply to this email directly, view it on GitHub https://github.com/home-assistant/core/pull/120381#issuecomment-2395177476, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOOVPLBXNOMNHCS5M7SUV3Z2BCALAVCNFSM6AAAAABJ25MFUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJVGE3TONBXGY . You are receiving this because you were mentioned.Message ID: @.***>

michaelkehoe avatar Oct 05 '24 20:10 michaelkehoe

In that case I would suggest just squashing all the commits with your other account and force pushing so it's all one commit. Unless you have a reason you're committing with this one, then I have to ask around why this happens

joostlek avatar Oct 05 '24 20:10 joostlek

Polite bump for review

michaelkkehoe avatar Oct 14 '24 03:10 michaelkkehoe

Bumping as well because this is a wonderful piece of hardware and deserves love inside home assistant.

Thanks!

visbits avatar Nov 18 '24 16:11 visbits

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar May 03 '25 09:05 github-actions[bot]

Bumping to keep open

michaelkkehoe avatar May 07 '25 03:05 michaelkkehoe

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. If you are the author of this PR, please leave a comment if you want to keep it open. Also, please rebase your PR onto the latest dev branch to ensure that it's up to date with the latest changes. Thank you for your contribution!

github-actions[bot] avatar Jul 06 '25 04:07 github-actions[bot]