android icon indicating copy to clipboard operation
android copied to clipboard

notifications - adds a test if a image-url source contains a GIF file

Open BitWuehler opened this issue 1 year ago • 4 comments
trafficstars

Adds a test if a image-url source contains a GIF file

Summary

Today I wanted to show a GIF in a notification an Android 14. I saw that this was added befor two weeks, Sadly this only works with URLs that ends with ".gif". Some URLs don't have the filename in the URL so i added a http header check for that.

Link to pull request in Documentation repository

The Documentation should be fine. The function is already described there.

Edit: I just checked the generated APK on my phone. Now the GIF works fine in notifications also with an URL without the filename.

BitWuehler avatar Apr 06 '24 00:04 BitWuehler

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:

Learn more about our pull request process.

home-assistant[bot] avatar Apr 06 '24 00:04 home-assistant[bot]

I think you've misunderstood what I was saying... There is a requiresAuth parameter that should be handled. At this point, paths are never relative because it is transformed here. If you're saying there is no way to serve a GIF from one of HA's built in proxies, that's also fine! No need for these complicated checks I think.

jpelgrom avatar Apr 07 '24 06:04 jpelgrom

I removed the Bytecheck now. The internal proxies also use http so bytecheck is not necessary. Just have to figure out how to check the internal url correctly now...

@jpelgrom

BitWuehler avatar Jun 18 '24 12:06 BitWuehler

As you are clearly still developing I'm going to change this to draft, mark it as ready once you're done :)

jpelgrom avatar Jun 20 '24 05:06 jpelgrom