Egor Homakov comments

Results 36 comments of


                                            Egor Homakov

trafficstars

Stop using browser modals

Yes, in fact we can call this issue to get rid of using any browser modals as they are ugly.

100 clock skew is too huge

There's no clock skeq requirement so 3 is rather a standard. Check sakurity.com/otp to see how bad it gets with 100.

WARNING !!!!! if you send bitcoin amount much less than you have, all the rest goes SILENTLY for fee !!!!!! You must warn everyone NOT to do test sending of very small amount !!!!

This must be fixed

support state params

@wafcio that's a vulnerability and should not be implemented

No constants

I tried to replace some vars and stuck at `utils.cmp is not a function`. The code otherwise looks great. Even if not for production, would serve as great reference implementation...

No constants

@patwhite i've done a lot of similar fixes too, so i will keep fixing my version @chjj why in tests both parties deposit in channel? ``` var channelCapacity = 10...