panel icon indicating copy to clipboard operation
panel copied to clipboard

I've pushed some gallery notebook changes to master by mistake

Open MarcSkovMadsen opened this issue 3 years ago • 6 comments
trafficstars

I was working on contributing some improvements to the gallery notebooks. Unfortunately I pushed to master.

  • I've added a SeabornStyle.ipynb notebook that I will need your help @philippjfr to add to the gallery. I will also need you to upload the seaborn-styles.gif file below similarly to the matplotlib-styles.gif.
  • I've corrected the wrong gif mentioned in https://github.com/holoviz/panel/issues/3731.
  • I've addressed https://github.com/holoviz/panel/issues/3730
$ git push
Enumerating objects: 35, done.
Counting objects: 100% (35/35), done.
Delta compression using up to 12 threads
Compressing objects: 100% (26/26), done.
Writing objects: 100% (26/26), 5.87 KiB | 182.00 KiB/s, done.
Total 26 (delta 21), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (21/21), completed with 9 local objects.
To https://github.com/holoviz/panel.git
   6d96647d..06b05fa5  master -> master

I'm not aware it will cause problems except the history.

Would it be possible to disable push to master without PRs? You should be able to protect the master branch by setting a policy https://stackoverflow.com/questions/46146491/prevent-pushing-to-master-on-github.

seaborn-styles

MarcSkovMadsen avatar Jul 30 '22 14:07 MarcSkovMadsen

I will fix it. Nothing to worry about.

EDIT: Seem like I don't have the right permissions. @maximlt can you see if you have permission to do it?

hoxbro avatar Jul 30 '22 15:07 hoxbro

The simplest non breaking way to resolve this, is to create a revert commit and push again to master.

mattpap avatar Jul 30 '22 16:07 mattpap

Please Conformance @Hoxbro or @philippjfr if this is What I should do?

MarcSkovMadsen avatar Jul 30 '22 16:07 MarcSkovMadsen

If you are unsure what to do, please don't do it. You haven't done anything which can't be fixed.

Just wait for someone other to fix it.

hoxbro avatar Jul 30 '22 16:07 hoxbro

Yeah don't worry about it. I wouldn't even revert it. If you added it to the right directory it'll appear in the gallery automatically. If you want to make further changes just makes those in a new PR.

philippjfr avatar Jul 30 '22 16:07 philippjfr

We can lock master, it's a little annoying because I usually push to master for dev releases.

philippjfr avatar Jul 30 '22 16:07 philippjfr