datashader icon indicating copy to clipboard operation
datashader copied to clipboard

Agree on JavasScript API for Bokeh/InteractiveImage

Open jbednar opened this issue 9 years ago • 4 comments
trafficstars

InteractiveImage requires access to parts of Bokeh's JavaScript API that keep changing in different Bokeh releases, leaving us playing catchup every time. We need to work with Bokeh to establish a clear API for this connection, and preferably to move InteractiveImage into Bokeh itself (as requested in #97).

jbednar avatar Sep 08 '16 13:09 jbednar

@jbednar, is there anything in particular that has been changed a lot recently? I looked at the code in datashader.bokeh_ext and didn't find too many references to bokehjs' APIs.

mattpap avatar Sep 08 '16 14:09 mattpap

Well, InteractiveImage has been broken by every new Bokeh release for the past several, so we must have some exposure! @philippjfr would know the details.

jbednar avatar Sep 08 '16 14:09 jbednar

It was all relatively minor issues, such as how to get a handle on the plot and how to get the width and height, both of which changed ever so slightly. I think the APIs I'm using now are stable though. Moving InteractiveImage into bokeh itself should be possible but relies on bidirectional communication between the frontend and the notebook kernel. I've already got some ideas on how to make that happen in future and I'll try to open an issue soon to outline a concrete proposal for adding callbacks that can communicate back to the kernel easily.

philippjfr avatar Sep 14 '16 16:09 philippjfr

Thanks!

@mattpap, can you look at the current version of InteractiveImage (it's pretty short) and see if you think that the current usage of Bokeh's JS API is indeed stable, and if so maybe mark that aspect of the API as something to protect?

jbednar avatar Sep 14 '16 16:09 jbednar