Holger Drewes
Holger Drewes
@kchojn Yes, can only agree: this is amazing! 🤩 Exciting to hear! ❤️
Side note: we likely want to run the reactivated trie benchmarks on this from #2969 with before and after results once we have this ready and the tests going.
Cool 🙏, seems pretty close already! 🙂 Can you do an in-between benchmarks run before and after and paste the results here?
Guess we need to put this on hold due to the performance results. Will give this a "blocked" label for now.
@roninjin10 Thanks a lot for the feedback, that helps a lot! I wanted to wait for our "self-contained examples" work (see some other now merged in PRs), so we basically...
Resolved merge conflict here and updated this via UI
Update: gave this another try. There is an issue open on Vitest support over on Bun which is still open: https://github.com/oven-sh/bun/issues/4145 and states that there is something in Bun still...
What was an interesting experiment though: I managed to switch over our [transaction test runner](https://github.com/ethereumjs/ethereumjs-monorepo/blob/master/packages/tx/test/transactionRunner.spec.ts) (which takes quite some time, >30 sec) to use the Bun native test runner (see...
After a short look I would say this is still a thing. (eventual existing code like the example referenced above needs to be adopted a bit due to our breaking...
This is a dramatic amount of work (a month+?), can we maybe have a closer look at times if we eventually can take this as a basis for a re-implementation...