Holger Drewes

Results 529 comments of Holger Drewes

Since this didn’t make it into production for close to a year, with one active try, I would also have a tendency to close. Feel free to reopen if you...

Hi there, we just updated our event emitter from the `async-eventemitter` package (outdated, not maintained) to `eventemitter2` and realized along the way that we lost the event-specific typing along with...

I think we should really do this. This will be also pretty valuable for ourselves to analyze stuff. Maybe we can start a bit small here? Guess we can take...

https://tohidhaghighi.medium.com/add-prometheus-metrics-in-nodejs-ce0ff5a43b44

Ok, noting some observations here. I am looking mainly at the "full" blocks with something around 800-1300 txs. Times for these all look a bit similar to this one: ![grafik](https://github.com/ethereumjs/ethereumjs-monorepo/assets/931137/c9e83a29-13a6-4d26-9d9e-00a096c6bbfe)...

So for the preparatory phase: Time here is lost (aka: consumed) more or less completely in the `await block.validateData()` call in [VM.runBlock() -> applyBlock()](https://github.com/ethereumjs/ethereumjs-monorepo/blob/e1221c98f3be0ba4224416f10d91ed4aa50130d8/packages/vm/src/runBlock.ts#L338) (so e.g. 396.08ms from 396.08ms for...

Additional side note: I find these numbers from above generally somewhat high for "memory only" operations, so this tx trie generation operates with a MapDB. 🤔 Another direction, but might...

One (rough) concrete idea for a cache that I have (actually for some time, this could be useful/improving for various other situations as well): That the resulting path respectively node...

👍 Cool that you are experimenting with this a bit! 🙂

Updated this via UI Can this get a review at some point? 🙏