browse-ocrd icon indicating copy to clipboard operation
browse-ocrd copied to clipboard

Update Docker

Open bertsky opened this issue 1 year ago • 1 comments
trafficstars

bertsky avatar May 23 '24 09:05 bertsky

@hnesk as you can see I am trying to get CI working again, but there are lots of problems in core ...

One thing I keep stumbling over here is a test that I don't quite understand how it could ever have worked and why it is included here: https://github.com/hnesk/browse-ocrd/blob/ca119726b95df1b9b5b3ed67cad5bfc0f3159330/tests/model/test_document.py#L182-L189

Basically, this must fail, because Workspace.image_from_page always gets you the last annotated image version (derived or original) satisfying the constraints. And that here of course turns out to be the image without a URL or copy in the file system.

~~Do you remember how this was intended?~~

EDIT

Now I understand. So this does yield an exception in core, but that is supposed to be caught in ocrd_browser, so the actual function returns none. Which it does – just the pytest output is confusing (because the whole stack trace is shown prior to "ok").

Also, I think I found the cause of the other failures: some of your test datasets still contained the old LOCTYPE="URL" notation, which is now reserved for true URLs, while local paths must use LOCTYPE="OTHER" OTHERLOCTYPE="FILE".

Let's hope this fixes CI :crossed_fingers:

bertsky avatar May 24 '24 11:05 bertsky