hlovdal

Results 89 comments of hlovdal
trafficstars

[Issue for the schematic failure](https://github.com/angular-eslint/angular-eslint/issues/790).

Is there anything that prevents this from being merged?

> It would be trivial to update the ruby script to add a summary of test failures at the end of the output. That sounds like an excellent idea in...

@dmnd Is there anything that blocks merging this?

The problem is the function ```javascript function getPosition(el) { return el._leaflet_pos || new Point(0, 0); } ``` which unconditionally dereferences `el`, while the safe version would look like ```javascript function...

And [latest version](https://hub.docker.com/_/mongo-express/tags) is now 1.0.0, [released last week](https://github.com/docker-library/official-images/pull/13162), supporting up to date versions of node.js and alpine. With #82 closed I think this issue can also be closed.

This is solved by [pull request 30](https://github.com/MrMufflon/Leaflet.Coordinates/pull/30).

> " I have to guess from the changes which is my feature and as a consequence which is upstream." @tuxayo unless you are using a proper 3-way merge program...

@sinclairzx81 Those links works fine now, but the branch is a moving target and the links are almost guaranteed to be broken when someone reads this in the future. Could...

And to automate the steps outlined by @yokrysty: ```bash VERSION=3.0.46 UPSTREAM_JAR=https://repo1.maven.org/maven2/io/swagger/codegen/v3/swagger-codegen-cli/$VERSION/swagger-codegen-cli-$VERSION.jar CLI_JAR="$(basename $UPSTREAM_JAR)" if [[ ! -f "$CLI_JAR" ]] then curl -Lo "$CLI_JAR" "$UPSTREAM_JAR" fi # Recent versions of swagger-codegen-cli...