Herman J. Radtke III

Results 96 comments of Herman J. Radtke III

> @hjr3 I'm confused why you made a domain/text for it. @dharmaturtle see https://github.com/ulid/spec/issues/25#issuecomment-457342085

The ask here is for `TypeNameIdentifierType` to accept `int8`. An 8byte integer is compatible with JS `Number` type. This is not asking for [BigInt in JS](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt) support.

Not sure this is solvable without leveraging more of cargo. The approach of compiling using rustc will lead us down a path of basically recreating cargo. Already looking at this...

I tracked this down to a missing `-L` arg when building the artifact. I will fix this in #218 but if that does not land, I will make a separate...

@steveklabnik I noticed these two flags were missing. The triage is probably the same as https://github.com/steveklabnik/rustdoc/issues/145 but I wanted to be thorough.

Some of these flags, such as `library-path`, moved from being a flag at the top level to being a flag for the `build` subcommand. I started down an approach to...

I probably need to chat with some folks in IRC about how we want these flags to work. See https://github.com/steveklabnik/rustdoc/issues/141#issuecomment-348743115 which discusses how `--test-args` should work. I also now wonder...

Similar to https://github.com/steveklabnik/rustdoc/issues/135#issuecomment-325030629 I am not sure if `--library-path` is needed. cargo supports configuring library paths through `build.rs`, which rustdoc honors when generating the analysis.

Per https://doc.rust-lang.org/book/first-edition/conditional-compilation.html, there does not seem to be a way to pass arbitrary configuration flags from cargo. We are limited to only toggling which features we want to be turned...

I was looking at starting to implement this and I am not sure we need this flag. The existing rustdoc would do something like `$ rustdoc x.rs --test --test-args --color=never`...