Hemant Joshi

Ah. Yes that does make sense. The expiration date is inside the attributes struct which has other things too. So I thought we could allow them to fetch that too....

Ah that makes sense. Let me write it up. Thank you for helping me out.

@gusfcarvalho https://github.com/external-secrets/external-secrets/pull/4709 created this PR.. I had to add the logic to add attributes to the metadata.. we werent fetching attributes.. everything was tag related i.e. we only allowed to...

This is definitely interesting @hariscodes. we are also in the migration of ingress to gateway api.. I would certainly love to take it up, research and implement it. Thank you...

@gusfcarvalho the test I added checks for expiry.. I will add checks for other fields too.. what other tests do you think I should add?

@gusfcarvalho does this look good now?

@Skarlso @gusfcarvalho is there any updates I should do for the above?

@Skarlso no issues. Sorry for the delay and the ping too. I think the sonarr qube thing is fixed now

@ivankatliarchuk @mloiseleur not sure what is up with the lint job. In my local `make go-lint` is working without any errors. This is the error in CI. The tests are...

@ivankatliarchuk sure I can change it back to start form empty cert pool no issues.. We can make that as part of a separate discussion