quark-shaders icon indicating copy to clipboard operation
quark-shaders copied to clipboard

License question

Open alice-mkh opened this issue 1 year ago • 5 comments

Hi, the readme says:

licensed under the General Public License v2

Does it mean GPL-2.0-only or GPL-2.0-or-later?

I noticed we use a shader (bicubic) marked as GPL-2.0+ while the readme seems to say otherwise, so I wonder if that's an oversight and we should remove it (the app is GPL-3.0-or-later so it's not compatible if the shaders are v2 only) or it's actually 2-or-later

alice-mkh avatar Aug 28 '24 23:08 alice-mkh

The shaders each have their own licenses. However, if the shader isn't being distributed as a compiled binary, you're just distributing a source file, which should be fine AFAIK. Of course, I'm not a lawyer, so don't interpret that as legal advice.

hizzlekizzle avatar Aug 29 '24 00:08 hizzlekizzle

I mean not all of them do - that one doesn't have a license specified, so it's using the one from readme.

alice-mkh avatar Aug 29 '24 00:08 alice-mkh

These shaders are (mostly) ported from other places. I need to go through and audit the licenses at some point.

For example, that one is a port of this guy (probably 3 hops worth of porting): https://github.com/libretro/common-shaders/blob/master/bicubic/shaders/bicubic-normal.cg

Luckily for you, it's GPLv2+ :)

hizzlekizzle avatar Aug 29 '24 13:08 hizzlekizzle

Yeah, I already did that ^^ (to this one: https://github.com/libretro/glsl-shaders/blob/master/cubic/shaders/bicubic.glsl) - it's more of a general question.

I was also thinking of using lcd-cgwg, but then I noticed there's a notice here, so that one should be good I think: https://github.com/libretro/common-shaders/blob/master/handheld/lcd-cgwg.cgp

alice-mkh avatar Aug 29 '24 13:08 alice-mkh

heh, license in the preset, jeeeeez

I think that one's just coming from the motionblur shader, but most of cgwg's contributions stick to GPLv2+, so you're probably safe there either way.

hizzlekizzle avatar Aug 29 '24 14:08 hizzlekizzle