New method to disable LoggingBootstrap via EmbeddedHiveMQBuilder
Motivation Disabling internal HiveMQServer LoggingBootstrap resolves class loading issues when incorporating the embedded version in frameworks like OSGi or Springboot.
Resolves issue #439
Changes
- EmbeddedHiveMQBuilder.java
- EmbeddedHiveMQBuilderImpl.java
- EmbeddedHiveMQImpl
- HiveMQServer
- EmbeddedHiveMQImplTest
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @janosch24 on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement
Thanks for signing the CLA @cla-bot check
The cla-bot has been summoned, and re-checked this pull request!
Regarding any required test coverage for this changes: I honestly haven't found any proper solution for testing. Using frameworks like Equinox or Spring Boot would introduce lot of (maybe unwanted) dependencies to the project during automated testing ...
Hi @janosch24,
Thank you for your contribution. Your pull request looks good to me and I will merge it soon, so it can be released end of this month.
Closed this PR and reopened it on the hivemq-community-edition repository to run CI. Ref: https://github.com/hivemq/hivemq-community-edition/pull/510