hivemq-community-edition icon indicating copy to clipboard operation
hivemq-community-edition copied to clipboard

New method to disable LoggingBootstrap via EmbeddedHiveMQBuilder

Open janosch24 opened this issue 1 year ago • 4 comments

Motivation Disabling internal HiveMQServer LoggingBootstrap resolves class loading issues when incorporating the embedded version in frameworks like OSGi or Springboot.

Resolves issue #439

Changes

  • EmbeddedHiveMQBuilder.java
  • EmbeddedHiveMQBuilderImpl.java
  • EmbeddedHiveMQImpl
  • HiveMQServer
  • EmbeddedHiveMQImplTest

janosch24 avatar May 15 '24 21:05 janosch24

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @janosch24 on file. In order for us to review and merge your code, please sign our Contributor License Agreement to get yourself added. You'll find the CLA and more information here: https://github.com/hivemq/hivemq-community/blob/master/CONTRIBUTING.adoc#contributor-license-agreement

cla-bot[bot] avatar May 15 '24 21:05 cla-bot[bot]

Thanks for signing the CLA @cla-bot check

sauroter avatar May 16 '24 08:05 sauroter

The cla-bot has been summoned, and re-checked this pull request!

cla-bot[bot] avatar May 16 '24 08:05 cla-bot[bot]

Regarding any required test coverage for this changes: I honestly haven't found any proper solution for testing. Using frameworks like Equinox or Spring Boot would introduce lot of (maybe unwanted) dependencies to the project during automated testing ...

janosch24 avatar May 16 '24 20:05 janosch24

Hi @janosch24,

Thank you for your contribution. Your pull request looks good to me and I will merge it soon, so it can be released end of this month.

Florian-Limpoeck avatar Jul 01 '24 16:07 Florian-Limpoeck

Closed this PR and reopened it on the hivemq-community-edition repository to run CI. Ref: https://github.com/hivemq/hivemq-community-edition/pull/510

Florian-Limpoeck avatar Jul 02 '24 12:07 Florian-Limpoeck