git-labelmaker icon indicating copy to clipboard operation
git-labelmaker copied to clipboard

Nothing updated

Open Berkmann18 opened this issue 7 years ago • 13 comments

I installed the package as a global one and followed the README, so I created a token with full repo access, I created all my labels but I can't find those labels nor do they appear in my labels when I go into a public repo.

Did I miss something or is this package not meant to work that way?

Berkmann18 avatar Jul 26 '18 21:07 Berkmann18

I typically get this to work on most of my repos. However, I have run into a few where it does not work, and I can't seem to figure out the pattern for why it doesn't.

shellscape avatar Dec 22 '18 13:12 shellscape

+1 does not seem to be working. I get Successfully created 31 labels put nothing happened. Also tried removing all existing labels and did not work. I got it to successfully work on one repo but doesn't work on others.

GregTheGreek avatar Jan 18 '19 17:01 GregTheGreek

Im wondering if its becasue existing issues are open?

GregTheGreek avatar Jan 18 '19 17:01 GregTheGreek

@GregTheGreek Perhaps, but I've used websites which allowed users to copy-paste/edit/delete labels even when existing issues were opened.

Berkmann18 avatar Jan 18 '19 17:01 Berkmann18

@Berkmann18 I just confirmed that open issues are not the problem. Although i found this bug #94

GregTheGreek avatar Jan 18 '19 17:01 GregTheGreek

@Berkmann18 I found a weird behaviour.

If you have renamed your repo, and have not updated the remote on your project locally it won't allow it to work.

GregTheGreek avatar Jan 19 '19 18:01 GregTheGreek

Hum, that's interesting...

Berkmann18 avatar Jan 19 '19 19:01 Berkmann18

I am having the same problem... Nothing actually got created.

image

EigenTheory avatar Jun 21 '19 15:06 EigenTheory

I made a PR to fix the endpoint https://github.com/himynameisdave/git-labelmaker/pull/96

MoisesFlores22 avatar Oct 16 '19 16:10 MoisesFlores22

@MoisesFlores22 If so you should add "Close"/"Fix"/... #90

Berkmann18 avatar Oct 16 '19 18:10 Berkmann18

my issues was with sso of my token, but we need someway to check the answer is given by the api

MoisesFlores22 avatar Oct 18 '19 21:10 MoisesFlores22

There's an issue in git-label that means any errors when creating the labels (e.g. already existing label or the token doesn't have the correct permissions etc.) don't get returned so the "successfully created" message gets displayed even though the request failed.

There's a PR in the git-label library here: https://github.com/jasonbellamy/git-label/pull/18.

huwshimi avatar Oct 15 '23 22:10 huwshimi

I see, hopefully that gets merged and solves the issue.

Berkmann18 avatar Oct 23 '23 19:10 Berkmann18