highlight.js icon indicating copy to clipboard operation
highlight.js copied to clipboard

Published 20 hours ago • verified publisher icon highlightjs

download page bug

Open BenRacicot opened this issue 1 year ago • 4 comments

Hi, when I select "all languages" on the downloads page and download, I get a 139 byte file that cannot be unzipped. Just reporting what I believe its a bug, hope this is helpful.

BenRacicot avatar Jan 18 '24 20:01 BenRacicot

Because the file will be too big. You'll get it if you open the zip file with a text editor. It'll be ok if you download "common" only.

tomwt-awa avatar Jan 20 '24 08:01 tomwt-awa

@allejo Couldn't we first add up the sizes of all the grammars (pre-zip) and have some magic threshold we set that tells people they picked too many - and to try again? We should not encourage builds with ALL the grammars anyways as that's just silly and forcing the browser to do extra parsing over and over for obscure grammars someone will never need.

joshgoebel avatar Jan 20 '24 15:01 joshgoebel

Yeah @joshgoebel was going to reply something similar, I actually didn't need the download because of Github files/releases.

Was looking for the CSS files and just reporting to help out.

BenRacicot avatar Jan 20 '24 15:01 BenRacicot

Do we have an "all" build in releases?

joshgoebel avatar Jan 20 '24 16:01 joshgoebel

FYi this is also tracked in https://github.com/highlightjs/highlightjs.org/issues/15

janbrasna avatar Mar 14 '24 22:03 janbrasna

Closing as dup of #15 from the website repo.

joshgoebel avatar Mar 19 '24 03:03 joshgoebel