highlight.js icon indicating copy to clipboard operation
highlight.js copied to clipboard

(nsis) Incorrect highlighting of keywords

Open idleberg opened this issue 2 years ago • 2 comments

Describe the issue

I have identified several cases where the highlighting for NSIS keywords is incorrect:

  • keywords should only highlight when at the beginning of the line (with or without leading whitespace)
  • keyword blocks should highlight both, the opening and closing keywords

See failing tests for specifics.

Which language seems to have the issue?

NSIS

Are you using highlight or highlightAuto?

Neither. I'm using the Mocha tests.

Expected behavior

Keywords should be highlighted correctly.

idleberg avatar Jul 16 '23 20:07 idleberg

@idleberg Any interest in coming back and finishing this one? Otherwise may close this issue for age. This seems to be an obscure language (at least based the activity level around it) and I try and limit our open issues to something reasonable, those we might expect someone to show up and be able to jump into.

If you'd like to flesh out your two items a bit further in the issue (so that someone not familiar with NSIS could maybe pick this up) with actual examples, failing cases, etc... we might be able to leave this around a while longer.

Thoughts?

joshgoebel avatar Oct 31 '24 23:10 joshgoebel

@joshgoebel Thanks for the reminder, I will give this another go

idleberg avatar Nov 03 '24 09:11 idleberg