highlight.js
highlight.js copied to clipboard
highlightjs
Add import operator to the JavaScript language definition
SEE: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/import
No issue made for this.
Changes
Added the import operator function statement to the list of BUILT_IN_VARIABLES and to the noneOf inside of the FUNCTION_CALL object, (although I'm not 100% sure if this is required)
Checklist
- [ ] Added markup tests, or they don't apply here because...
- [ ] Updated the changelog at
CHANGES.md
Does such a small edit need an edit of changes.md?
Does such a small edit need an edit of changes.md?
Yes.
I wonder though if this shouldn't be a built-in global or even a keyword? variable seems wrong OTTOMH.
I don't know man, I just changed it for myself and thought, I guess I could make a pull request.
Also: how do I test out the highlighting, like have it spit out a demo page where I can insert code into, so I can test out if the changes I've made work or not.
so I can test out if the changes I've made work or not.
See the Building and Testing documentation. Build a browser release. Then fire up ./tools/developer.html, that's the easiest way.
I just changed it for myself and thought, I guess I could make a pull request.
What exact problem were you trying to solve with this patch?
Need to close this up soon if you'd like it in 11.7... that may be the last release before 12.
@nathnolt Thanks so much, I went ahead and pushed this all the way home.