serverless-redis-http icon indicating copy to clipboard operation
serverless-redis-http copied to clipboard

Does not work for clustered Redis

Open GRVYDEV opened this issue 1 year ago • 3 comments

Hey there. I noticed this does not work for clustered redis. Do you have any advice for fixing this?

GRVYDEV avatar Sep 04 '24 23:09 GRVYDEV

The main thing that would need to change is the client_worker which specifically opens a Redix connection -- https://github.com/hiett/serverless-redis-http/blob/794c5a372fa3997e08320250235f32e5a86338a3/lib/srh/redis/client_worker.ex#L83

which obtains information from an ETL table created by https://github.com/hiett/serverless-redis-http/blob/794c5a372fa3997e08320250235f32e5a86338a3/lib/srh/auth/token_resolver.ex#L59

I am pretty packed out for the next week, so likely won't have time to try create my own local cluster and tinker through to figure it out anytime super soon. But this is something I am definitely interested to add support for!

hiett avatar Sep 04 '24 23:09 hiett

Thanks for the quick response! Let me see if I can make some time this weekend to dust off my elixir skills and open a PR!

GRVYDEV avatar Sep 05 '24 00:09 GRVYDEV

Sounds good! If you change the JSON schema for the config file, make sure it's backwards compatible -- a ton of people are running rather old versions and have recently been updating so I want to make sure this is opt-in

hiett avatar Sep 05 '24 00:09 hiett