sshj icon indicating copy to clipboard operation
sshj copied to clipboard

Add overloaded init methods that take the public key from a stream an…

Open dkocher opened this issue 2 years ago • 2 comments
trafficstars

…d properly initialize. Resolves #907.

dkocher avatar Oct 23 '23 19:10 dkocher

Codecov Report

Attention: Patch coverage is 45.00000% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 68.50%. Comparing base (03f8b22) to head (17fe2ab). Report is 8 commits behind head on master.

:exclamation: Current head 17fe2ab differs from pull request most recent head 9edc75f. Consider uploading reports for the commit 9edc75f to get more accurate results

Files Patch % Lines
...sshj/userauth/keyprovider/OpenSSHKeyV1KeyFile.java 23.52% 11 Missing and 2 partials :warning:
...sshj/userauth/keyprovider/BaseFileKeyProvider.java 61.53% 2 Missing and 3 partials :warning:
...mizz/sshj/userauth/keyprovider/OpenSSHKeyFile.java 60.00% 2 Missing and 2 partials :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #908      +/-   ##
============================================
- Coverage     68.96%   68.50%   -0.47%     
+ Complexity     1448     1416      -32     
============================================
  Files           208      207       -1     
  Lines          7602     7529      -73     
  Branches        658      642      -16     
============================================
- Hits           5243     5158      -85     
- Misses         2009     2028      +19     
+ Partials        350      343       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Oct 23 '23 20:10 codecov-commenter

Not sure how to update the code coverage report with updated results from the force pushed commit.

dkocher avatar Oct 23 '23 21:10 dkocher

@dkocher if you can bring this back up to date with the base branch, and see whether coverage can be improved slightly to make the codecov happy, I'll merge this so that we can bring out a new version.

hierynomus avatar Apr 23 '24 08:04 hierynomus