sshj icon indicating copy to clipboard operation
sshj copied to clipboard

Retry partial authentication with all remaining auth methods (Fixes #812)

Open hierynomus opened this issue 3 years ago • 3 comments

hierynomus avatar Sep 23 '22 20:09 hierynomus

Codecov Report

Merging #820 (d7dd73b) into master (6e7fb96) will decrease coverage by 0.01%. The diff coverage is 59.09%.

@@             Coverage Diff              @@
##             master     #820      +/-   ##
============================================
- Coverage     64.84%   64.83%   -0.02%     
- Complexity     1467     1468       +1     
============================================
  Files           210      211       +1     
  Lines          8537     8553      +16     
  Branches        781      785       +4     
============================================
+ Hits           5536     5545       +9     
- Misses         2592     2597       +5     
- Partials        409      411       +2     
Impacted Files Coverage Δ
src/main/java/net/schmizz/sshj/SSHClient.java 58.60% <50.00%> (-1.06%) :arrow_down:
...n/java/net/schmizz/sshj/userauth/UserAuthImpl.java 77.19% <50.00%> (-4.63%) :arrow_down:
...ain/java/net/schmizz/sshj/userauth/AuthResult.java 100.00% <100.00%> (ø)
.../main/java/net/schmizz/sshj/sftp/PacketReader.java 95.74% <0.00%> (+4.25%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 24 '22 08:09 codecov-commenter

I can backport some of our changes with plenty of tests, though they're in Kotlin, which would require time for complete rewriting to Java.

vladimirlagunov avatar Sep 26 '22 10:09 vladimirlagunov

Sorry for taking so long to get to this. I tested this branch with nifi and unfortunately I still get the same error of "net.schmizz.sshj.userauth.UserAuthException: Exhausted available authentication methods" when the order is backwards from how the AuthMethods are added to the client.

jamespowenjr avatar Oct 18 '22 15:10 jamespowenjr