license-gradle-plugin icon indicating copy to clipboard operation
license-gradle-plugin copied to clipboard

excludeDependency still gets parsed

Open makuk66 opened this issue 10 years ago • 2 comments

I've run into a scenario where a transitive dependency (org.codehaus.plexus:plexus:1.0.4) I pull in has an xml parsing problem (an undefined entity), and causes a SAXParseException. I tried adding it to excludeDependencies, but it still fails.

Here is a minimal reproduction repository: https://github.com/makuk66/GradleLicensePlexus Clone that repo, and run gradlew downloadLicenses

build.gradle: https://github.com/makuk66/GradleLicensePlexus/blob/master/build.gradle output: https://github.com/makuk66/GradleLicensePlexus/blob/master/output.txt

Should the plugin parser know about those entities? Should the excludeDependencies entry cause this to be skipped?

Related reports with other tools: https://issues.apache.org/jira/browse/IVY-921 (Ivy added entities) https://issues.apache.org/jira/browse/JCR-666 (recommended parser change) http://sourceforge.net/p/artifactory/mailman/artifactory-users/?viewmonth=201001&page=2

makuk66 avatar Oct 27 '15 21:10 makuk66

I seem to recall I made a change to the parser already, as this issue was encountered before. Which version are you using?

hierynomus avatar Dec 16 '15 10:12 hierynomus

Per https://github.com/makuk66/GradleLicensePlexus/blob/master/build.gradle#L3 that was 0.12.1

makuk66 avatar Dec 16 '15 17:12 makuk66