hibernate-orm issues

HHH-15216 Cannot change MetadataProvider implementation because JPAXMLOverriddenMetadataProvider is final and precisely expected by a cast operator

This PR moves `JPAXMLOverriddenMetadataProvider` out of package `internal` and makes it non final.

HHH-11888 : Different Behavior on insertable of @JoinColumn of @OneToMany field between Hibernate4/Hibernate5

1

…Many field between Hibernate4/Hibernate5 Different Behavior on "insertable" of "@JoinColumn" of "@OneToMany" field between Hibernate4/Hibernate5 First the 'joincolumn' was added to 'SampleValue' with default insertable/updatable as true and later while...

sumita-mudgil

HHH-15050 Fix NullPointerException in StatefulPersistenceContext.extractNaturalIdValues()

7

StatefulPersistenceContext.extractNaturalIdValues(). See example below. https://hibernate.atlassian.net/browse/HHH-15050 ``` Caused by: java.lang.NullPointerException at org.hibernate.engine.internal.StatefulPersistenceContext$1.extractNaturalIdValues(StatefulPersistenceContext.java:2163) at org.hibernate.persister.entity.AbstractEntityPersister.handleNaturalIdReattachment(AbstractEntityPersister.java:4956) at org.hibernate.persister.entity.AbstractEntityPersister.afterReassociate(AbstractEntityPersister.java:4930) at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.performUpdate(DefaultSaveOrUpdateEventListener.java:322) at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.entityIsDetached(DefaultSaveOrUpdateEventListener.java:230) at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:95) at org.hibernate.event.internal.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:75) at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:107) at org.hibernate.internal.SessionImpl.fireSaveOrUpdate(SessionImpl.java:670) at org.hibernate.internal.SessionImpl.saveOrUpdate(SessionImpl.java:663) at...

garydgregory

HHH-15102 Processing of annotation recognition in BasicFormatterImpl

1

https://hibernate.atlassian.net/browse/HHH-15102 I use making SQL statements pretty in BasicFormatterImpl. However, if there is a comma behind the annotation, the column behind the annotation is sent to the next line to...

skarbgud

HHH-15065: Add minimal reproducer and a suggested fix for 5.6

The [first commit](https://github.com/hibernate/hibernate-orm/pull/4766/commits/876863a5b41ef78ff8b67fb37f4790b0b8ccfead) introduces a minimal reproducer for [HHH-15065](https://hibernate.atlassian.net/browse/HHH-15065). The test fails most of the times but with some luck it is green. The [second commit](https://github.com/hibernate/hibernate-orm/pull/4766/commits/e08e64f863e6e9f5c39926857f9a9c42d8eded41) contains my suggestion how...

bwaldvogel

HHH-15063 Add test for orphan removal of OneToOne inside Embeddable

This is an example of failing test for issue https://hibernate.atlassian.net/browse/HHH-15063

phalasOhpen

change getNationalizationSupport() on Sybase to use UNSUPPORTED

5

`getNationalizationSupport()` currently returns `IMPLICIT` for the jTDS driver. But from the comment I _think_ it should probably return `UNSUPPORTED`. WDYT @sebersole @beikov ?

gavinking