hibernate-orm
hibernate-orm copied to clipboard
HHH-15443 Allow JdbcType to wrap read and write expressions
https://hibernate.atlassian.net/browse/HHH-15443
I'm not sure I like what's going on here, but that could just be because I don't understand it. Could we talk it over sometime?
OK, so after discussing offline, my suggestion is that it would be better if this worked by having the Type double-dispatch back to the Dialect, and let the Dialect render the SQL.
The justification for this is: the generated SQL in principle depends on both the Type and the Dialect, and the SQL syntax in principle is a responsibility of the dialect.
Thanks for your pull request!
This pull request does not follow the contribution rules. Could you have a look?
❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
↳ Offending commits: [b6ebf2a9bf0a8eaec06685ab205ccf47862c35d3]
› This message was automatically generated.
Marked as non-draft to run the Actions. Though they are still not running - presumably because of the changes to the CI set up being just in this PR?
Merged via 7564551f6e85f52076a7b7fcb7e68c507393c261 and 16ca1a0595eb304348ebe2a2a126b0362f30d1ef