hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

HHH-15317 DeepCopy fields when marking an entity non-readonly

Open ahus1 opened this issue 3 years ago • 1 comments

Otherwise a modification might get unnoticed in the next flush.

This is a draft PR for now as it doesn't yet contain a test case, and I'm not sure which branch to submit this one to.

I'd be happy for some advice:

  • if submitting the PR for 5.6 is ok, as I'd like to see a fix for 5.6 - or should I rather submit it for 6.0?
  • could you point me to a test case example I could extend that already uses some custom types?
  • could the test cases be more minimized?
  • between 6.0 and 5.6 some classes about user defined types changed - see migration guide. Should I eventually submit two PRs?

Thanks!

ahus1 avatar Jun 05 '22 20:06 ahus1

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

Hello, please also create a PR against main and include the test you created in the PR. You can create a new test, preferrably in the org.hibernate.orm.test.readonly package. Create new entities similar to e.g. org.hibernate.orm.test.annotations.basic.CollectionAsBasicTest and write your test similar to org.hibernate.orm.test.readonly.ReadOnlyTest.

beikov avatar Oct 31 '22 15:10 beikov

Obsolete due to the work in #7355

ahus1 avatar Sep 25 '23 07:09 ahus1