hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

HHH-14631 add Sakila sample database as new testing domain model

Open NathanQingyangXu opened this issue 4 years ago • 7 comments

https://hibernate.atlassian.net/browse/HHH-14631

Sakila is a well-known MySQL sample database modelling dvd rental store: https://dev.mysql.com/doc/sakila/en/ A HR example database in Oracle is also included.

We might consider other sample databases as per https://data-xtractor.com/blog/data-modeling/example-databases/.

NathanQingyangXu avatar May 23 '21 02:05 NathanQingyangXu

Do we need to do anything special here with copyrights and/or licenses?

sebersole avatar Jan 27 '22 00:01 sebersole

Do we need to do anything special here with copyrights and/or licenses?

I have no idea in this respect. @beikov , @dreab8 @Sanne how do you think?

NathanQingyangXu avatar Apr 25 '22 12:04 NathanQingyangXu

I don't know for sure, but other projects that provide a Sakila sample database provide it under the BSD-2 license which seems to be the original license of the MySQL example model, though these projects provide the actual SQL DDL and Hibernate would just emit compatible SQL DDL. Maybe @Sanne knows more, but from my understanding, it should be be put under BSD-2 license.

beikov avatar Apr 25 '22 13:04 beikov

We'd definitely want to investigate the implication of BSD on LGPL and make it abundantly clear that the BSD only applies to those classes

sebersole avatar Apr 25 '22 14:04 sebersole

@NathanQingyangXu how did you create these classes? I assume via reverse engineering from the actual DB?

Sanne avatar Apr 26 '22 10:04 Sanne

Nope, I created these classes purely based on the open documentations.

On Tue., Apr. 26, 2022, 6:57 a.m. Sanne Grinovero, @.***> wrote:

@NathanQingyangXu https://github.com/NathanQingyangXu how did you create these classes? I assume via reverse engineering from the actual DB?

— Reply to this email directly, view it on GitHub https://github.com/hibernate/hibernate-orm/pull/4004#issuecomment-1109652800, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6UYATZ36KOWNOCM3OXB73VG7D2RANCNFSM45LG5Q2Q . You are receiving this because you were mentioned.Message ID: @.***>

NathanQingyangXu avatar Apr 26 '22 11:04 NathanQingyangXu

Ok then they are not BSD licensed, and you can choose to contribute them to the Hibernate project as LGPL (like you did in the headers), so it should be all good

Sanne avatar Apr 26 '22 11:04 Sanne