hibernate-orm icon indicating copy to clipboard operation
hibernate-orm copied to clipboard

HHH-10550: Replaced int cast/usage for long implementation

Open luiscla27 opened this issue 4 years ago • 4 comments

Fixes https://hibernate.atlassian.net/browse/HHH-10550

luiscla27 avatar Jan 13 '21 23:01 luiscla27

Thsnks for the bug reporting and the PR. Seems a good catch and fixing. The only thing that is missing is a testing case which shows:

  1. without the code fixes it would be broken;
  2. with the code fixes it would succeed.

Usually there is slim chance for the PR to be accepted without such compelling testing case (unless the PR is to fix some documentation). Please see existing testing cases to get the clue how to come up with one. It is not difficult and coding such testing case is both fun and mandatory.

NathanQingyangXu avatar Jan 23 '21 21:01 NathanQingyangXu

Thank you for taking a look in this PR :)

I'll check existing tests, it might be specially hard to create one for this issue, specially because the test-case would need to hold in memory a binary which exceeds the value of the Integer.MAX_VALUE constant (2,147,483,647 bytes). Any suggestion??

In my real world use-case issue that's actually what is happening...

luiscla27 avatar Jan 23 '21 21:01 luiscla27

Thank you for taking a look in this PR :)

I'll check existing tests, it might be specially hard to create one for this issue, specially because the test-case would need to hold in memory a binary which exceeds the value of the Integer.MAX_VALUE constant (2,147,483,647 bytes). Any suggestion??

In my real world use-case issue that's actually what is happening...

Could you mock something to simulate that then?

NathanQingyangXu avatar Jan 23 '21 22:01 NathanQingyangXu

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [092a0a849b5835206e01ba1bcc7f65b274bef780, 98261c50cff69baa57c5b64d5d3835a90595c01d, be774d16a107c8b3c7e71afa001132a7207ff8e7, f4563ac3a27397bad2bdabb17149e1e26a3f8265, deecf5c164cac5dfab3faa387e9a1c7acdf0614f, 507c50a2d05a18dca3ad41d5c4257130cd308b2d, 63d74908fea9246390176311095b21c8782ef705]

› This message was automatically generated.