HHH-14055 - Add UUID support for fields annotated with @RevisionNumber

[bbanchev]

Add fallback check if the field type is of type java.util.UUID Update corresponding MappingException message

[sebersole]

@RevisionNumber explicitly says that "values of this property should form a strictly-increasing sequence of numbers". A UUID obviously does not fit that description.

@Naros you are much better versed in envers than I... what do you think?

[bbanchev]

@RevisionNumber explicitly says that "values of this property should form a strictly-increasing sequence of numbers". A UUID obviously does not fit that description.

@Naros you are much better versed in envers than I... what do you think?

Actually this is one of the main reasons to ask for this feature - need unpredictable id sequence for revisions. On the other hand fits better in distributed environment.

[sebersole]

When a contract explicitly says "should do X" and something explicitly breaks that contract... I like to have an expert explain the ramifications.

Whether using a UUID would work better in distributed environment, it is irrelevant if the code-base truly expects sequentiality. So let's just wait to hear from Chris

On Tue, Jun 2, 2020 at 8:13 AM Borislav Banchev [email protected] wrote:

@RevisionNumber explicitly says that "values of this property should form a strictly-increasing sequence of numbers". A UUID obviously does not fit that description.

@Naros https://github.com/Naros you are much better versed in envers than I... what do you think?

Actually this is one of the main reasons to ask for this feature - need unpredictable id sequence for revisions. On the other hand fits better in distributed environment.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hibernate/hibernate-orm/pull/3425#issuecomment-637533629, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZIE354XZZVZ7PQRFHIIDRUT3H3ANCNFSM4NQWXYEQ .

[hibernate-github-bot[bot]]

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+     ↳ Offending commits: [eb7892cf9d84f7e05fda24d8ab7530398fb06451]

› This message was automatically generated.