pourover icon indicating copy to clipboard operation
pourover copied to clipboard

Published 20 hours ago • verified publisher icon hhsnopek

Refactor source

Open hhsnopek opened this issue 10 years ago • 6 comments

The current source of PourOver is a bit messy and can be cleaned up. Possibly removing all dependencies in the process or just underscore.

  • [ ] snake_case to camelCase of all methods and variables.
  • [ ] Refactor into Prototypal OO
  • [ ] Change documentation to JSDoc3
  • [ ] Convert to ES6

hhsnopek avatar May 28 '15 17:05 hhsnopek

I'd be interesting in exploring this a bit, I'll start idling in the gitter chat so we can talk it out.

TomNeyland avatar Jun 19 '15 19:06 TomNeyland

Awesome! I'm always idle in the channel - ping me when you can :D

hhsnopek avatar Jun 19 '15 19:06 hhsnopek

Cool. I would advocate refactoring into several commonjs files, replacing underscore with individual lodash.* dependencies, and using browserify to create a distributable version.

nichoth avatar Sep 28 '15 22:09 nichoth

@nichoth I'm actually going for es6 modules and splitting everything similarly but using folders just like moment.js

hhsnopek avatar Sep 29 '15 02:09 hhsnopek

Cool I haven't worked with es6 things yet

nichoth avatar Sep 29 '15 15:09 nichoth

the only thing from emca2015 that I'm taking is the import/export modules

hhsnopek avatar Sep 29 '15 19:09 hhsnopek