openmoji icon indicating copy to clipboard operation
openmoji copied to clipboard

Some black elements in SVG sources are being rendered with current font colour in TTF font

Open kevincox opened this issue 4 years ago • 10 comments
trafficstars

It appears that some strokes on the emoji use the font colour. This looks bad when the font colour is not black as expected.

Example:

<span style=color:black>😃</span>
<span style=color:white>😃</span>
<span style=color:blue>😃</span>
<span style=color:green>😃</span>

image

Expected behaviour:

Most emoji should not incorporate the default font color into the design.

kevincox avatar Aug 15 '21 20:08 kevincox

🏝 OpenMoji is on hold over summer (project maintainers are out of office until Oct 2021).

github-actions[bot] avatar Aug 15 '21 20:08 github-actions[bot]

Closed as discussed in #340 Sorry!

b-g avatar Oct 05 '21 14:10 b-g

Sorry why is this closed? This is a bug with the generated TTF files and is still an issue even if you don't want to change the SVG sources. I understand if you think that the proposed fix was the wrong one but this problem definitely still exists.

kevincox avatar Oct 05 '21 14:10 kevincox

See https://github.com/hfg-gmuend/openmoji/pull/340#issuecomment-934506437

Yes the problem still exist ... but we haven't written the font generator https://github.com/13rac1/scfbuild nor the piece of software which renders colorfonts in your browser of choice :) So I don't see any responsibility for it on the OpenMoji side.

But now that I'm thinking of it ... maybe an easy fix / compromise might be to add a default color to the openmoji.css and define there a default color?

b-g avatar Oct 05 '21 15:10 b-g

The openmoji.css only affects users who are using a browser and using that style. It won't help system-font usage or other cases.

Well you have a copy of the built font file in your repo so it seems that you are taking some responsibility for the generation. The argument would make sense if the project was just the SVG files but it seems like it is also maintaining a build process for fonts using pinned versions of dependencies so it is unclear how it could be fixed anywhere else. If you think it is a bug with scfbuild I can also open a bug upstream, but it seems like we would still want to keep this bug open to update the build process and checked in font file to use the newer version.

kevincox avatar Oct 05 '21 15:10 kevincox

Please take care of the bug upstream. I'm not taken any responsibility for anything font generated related, this is why we have clearly stated (see OpenMoji.org and FAQ):

**OpenMoji-Black.ttf proof of concept version, some glyphs are broken, not intended for production use!

OpenMoji-Color.ttf beta version, works in Firefox / Edge / Adobe CC, see discussion, not intended for production use!**

b-g avatar Oct 05 '21 15:10 b-g

Re-opened: https://github.com/hfg-gmuend/openmoji/pull/340#issuecomment-936074516

b-g avatar Oct 06 '21 11:10 b-g

@kevincox ok. Can you think of a more descriptive name for the issue? e.g.

Problems with SVG default color in font files?

b-g avatar Oct 06 '21 11:10 b-g

I'm not sure this is completely accurate either because my fix didn't completely solve the problem. How about "Some black elements in SVG sources are being rendered with current font colour in TTF font"?

kevincox avatar Oct 06 '21 13:10 kevincox

@kevincox Many thanks, renamed! FYI we really tried hard to make the fonts work and initially thought we could heal all the issues by simply switching the build process to nanoemoji ... after an endless saga #260 and a lot of effort, we stopped as nanoemoji introduced other issues. However as nanoemoji is still actively maintained (and backed by Google) it makes probably more sense to put any upstream effort into the nanoemoji project and not scfbuild.

b-g avatar Oct 07 '21 13:10 b-g