docker-elixir icon indicating copy to clipboard operation
docker-elixir copied to clipboard
verified publisher icon hexedpackets

Refactoring - Better HTTP responses and streams handling, and test coverage

Open Strift opened this issue 8 years ago • 2 comments

Hey,

Thanks for what you've done! I use this package in an application at work, but we needed to refactor it a lot in order to make it work. We tried to make it more reusable and included a lot more unit tests.

I suggest this PR just so you can review the code. Let me know if you're interested in such pull requests.

If you do, I will take time to finish the tests and the documentation, and we can figure out together which conventions we should follow.

Looking forward to hear from you :)

Strift avatar Jul 26 '17 12:07 Strift

Awesome, glad to hear this was useful for you! I just got back from some traveling and haven't had a chance to look through your changes yet. I'm definitely interested in getting them merged and I'll try to read through everything this week.

hexedpackets avatar Aug 02 '17 14:08 hexedpackets

Hey there,

Did you have time to read the code? Let me know if you have any questions!

Looking forward to hear from you again :)

Strift avatar Aug 08 '17 09:08 Strift