hcloud-cloud-controller-manager icon indicating copy to clipboard operation
hcloud-cloud-controller-manager copied to clipboard

refactor(hcops): cleanup AllServersCache

Open apricote opened this issue 1 year ago • 1 comments

This separates accessing the cache from loading the data and renames some identifiers to better represent their purpose.

apricote avatar Jul 02 '24 13:07 apricote

Codecov Report

Attention: Patch coverage is 75.86207% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.81%. Comparing base (8656812) to head (2b769bb).

Files Patch % Lines
internal/hcops/server.go 75.86% 6 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   71.89%   71.81%   -0.08%     
==========================================
  Files          32       32              
  Lines        2658     2672      +14     
==========================================
+ Hits         1911     1919       +8     
- Misses        556      561       +5     
- Partials      191      192       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jul 02 '24 13:07 codecov[bot]