heroku-pipelines icon indicating copy to clipboard operation
heroku-pipelines copied to clipboard

Published 20 hours ago • verified publisher icon heroku

Properly inform the user if he has not enabled the GitHub integration when diffing

Open krummi opened this issue 10 years ago • 7 comments
trafficstars

This PR adds better error messaging when someone does heroku pipelines:diff and has not enabled the GitHub integration for his Heroku account.

Before: Before

After: After

krummi avatar Oct 28 '15 08:10 krummi

Oh wow, we really dropped the ball on this one. @krummi would you mind rebasing?

gudmundur avatar Feb 04 '16 13:02 gudmundur

No problem ;) working on rebasing! Will hopefully manage to finish it tomorrow.

krummi avatar Feb 10 '16 23:02 krummi

I would really love to see this get merged, please

rogusdev avatar Feb 03 '17 00:02 rogusdev

@krummi nudge nudge. :)

gudmundur avatar Feb 07 '17 15:02 gudmundur

Oh sorry guys, I'm terribly busy with my studies. I will take a look at this as soon as I can though. :)

krummi avatar Feb 21 '17 21:02 krummi

I'll try to pick up the rebase when I've got a slow moment. Will probably open up another PR for this as I can't push to your branch @krummi. Is that alright with you?

gudmundur avatar Apr 06 '17 11:04 gudmundur

Absolutely @gudmundur. Sorry I haven't found the time to fix this! It should be simple though.

krummi avatar Apr 11 '17 12:04 krummi