helper-markdown
helper-markdown copied to clipboard
Upgrade highlight.js dependency to v10
Hello Team,
This is problem about the latest dependency about highlight.js related here: https://github.com/highlightjs/highlight.js/issues/2877
Is it possible to upgrade you highlight dependencies to v10 please :)
See you Romain
At a glance I think this should be pretty straightforward.
I would love it if you could update this to version 10 of highlight.js.
I'm starting to get folks logging issues on my repo due to this dependency 😢 - If there anything I can do to help please let me know. 🙏🏻
Unfortunately I don't have time to make PRs for every downstream library but if someone just bumped the dependencies here and then played around a bit that might get them really far. It's always hard to call these things with just a glance but our public API between v9 -> v10 was actually super stable. You could read the Version 10 release notes to see what changed, but for many, many people upgrading was super simple - despite many small breaking changes.
We no longer support IE11 is the big change that might bite some people. (though that wouldn't matter if you were running this on the server-side).
Wrote a very tiny guide:
https://github.com/highlightjs/highlight.js/issues/2882
Hey @jonschlinkert / @doowb / @almeidap
Is there any chance that you could take a look at this issue, please? 🙏
@joshgoebel @DannyDainton @almeidap PR => https://github.com/helpers/helper-markdown/pull/17
Hey, the linked highlightjs 9.x version has a reported security vulnerability https://snyk.io/test/npm/helper-markdown/1.0.0
There are 2 Pull requests that request to bump to v10: https://github.com/helpers/helper-markdown/pull/17 https://github.com/helpers/helper-markdown/pull/16
@jonschlinkert @doowb @almeidap Could you help to merge it to address the security risk?
👋 Hi @jonschlinkert @doowb I apologise for the inconvenience, unfortunately for now the only way to get the update for this library is to ask you. Could you find the time to update it? If you don't have time, can you invite someone (I volunteer) to help maintain the library?