helix icon indicating copy to clipboard operation
helix copied to clipboard

Improved diagnostics picker formatting

Open CptPotato opened this issue 3 years ago • 1 comments

The current layout for the diagnostics picker is not that great. The file path takes up a lot of space (for example \c\U\a\s\h\h\s\c\lsp.rs) and most of the diagnostic text is cut off as a result:

screenshot

image

My suggestion is to nest the diagnostics for each file like this for example:

image

This reduces the redundant file paths and allows to show more of the actual diagnostic message.

However, I'm not sure how well this integrates into the picker, since it expects a flat list where each entry can be selected from what I can tell. It's also not 100% clear to me how searching should be implemented using this layout.

CptPotato avatar Oct 13 '22 08:10 CptPotato

Maybe we could re-use the tree display from #2377 for this?

the-mikedavis avatar Oct 13 '22 15:10 the-mikedavis

Something like this would also be nice for global search, see #5730. I think it makes sense to track all of these feature requests in this issue because any solution to this problem should be generic and not just applied to a single picker.

pascalkuthe avatar Jan 30 '23 12:01 pascalkuthe