helix
helix copied to clipboard
Show selection over bracket matching
Currently the bracket matching was covering selection edges, making it impossible to see if a bracket was selected or not. This PR disables bracket matching when the selection edge is over the matching bracket.
This seems more of a theme issue? It should be possible to visualize both the matching bracket and the selection cursor at the same time.
This seems more of a theme issue? It should be possible to visualize both the matching bracket and the selection cursor at the same time.
You're right. It is possible but then you can't set both fg and bg for the bracket matching:
with fg and bg (selection on ) is not visible):

with fg only:

I can't comment on the implementation but I think it's a decent change. Then again, I never found this to be an issue myself.
I am closing this PR as stale as it has conflicts and I don't see us going in this direction.
Thank you for contributing!