helix icon indicating copy to clipboard operation
helix copied to clipboard

[book] Code blocks in light modes are poorly readable

Open sgued opened this issue 3 years ago • 1 comments

Hi! Thanks for all your work on helix, it's great!

Code blocks in the book are barely readable in the light themes of the book, because some color variables are taken from the dark themes:

image

This is true both for inline code blocks and for normal code blocks.

image

For reference, this is what it looks like without any custom CSS:

image

It is overall much more readable in a light mode context.

I also noticed that the default theme is a dark one. IMO this is a mistake and the default theme should be a light theme. mdbook is smart enough to read use the browser's setting and switch to preferred-dark-theme when appropriate.

sgued avatar Sep 09 '22 17:09 sgued

The Configuration page has a particularly hard to read part: Screenshot from 2022-10-17 16-57-38

rgoulter avatar Oct 17 '22 09:10 rgoulter