Make matching brace higlighting configurable

[A-Walrus]

Resolves #3228 by making matching brace highlighting configurable: none, all, primary, defaulting to all.

New default behavior:

[the-mikedavis]

Instead of having this configurable with a config option it could just use theme rules: ui.cursor.match.primary themes the primary match and ui.cursor.match.secondary the secondary cursor matches

[the-mikedavis]

I think secondary cursor match highlighting is pretty noisy. I only use the primary match in cases where I'm not sure what nesting level I'm on and if it were toggle-able I would probably only enable showing the primary match sparingly. I don't run into the same use-case for secondary matches so I most likely would not enable this in my theme.

Maybe this should be configurable in editor config rather than theme? It could be set to all, primary or none for showing these and still have these ui.cursor.match.{primary,secondary} scopes for theming. What do others think?

Sorry for the bike-shedding 😅

[AlexanderBrevig]

As a new user (not that many days ago) my knee jerk reaction to not seeing color modes after enabling it made me think it was a bug with Helix. In fact is was just my theme not being up to date, and I would call that a bug too (fixed in a PR of course :) ).

I feel (rather strongly) that a Helix theme should accommodate all Helix features. Opting in/out of feature x should not imply editing a theme or changing a theme imho.

My 0b10 😊

[pascalkuthe]

clsoing this PR as stale. I also dont think we will be going forward with this (see mikes comment above).

Thank you for contributing!