Ankit Dash comments

Results 35 comments of


                                            Ankit Dash

trafficstars

Improve `fromTemplate.test.ts` to avoid intermittent error on CI

Hello @Shurtu-gal, I am interested in working on this issue. So as suggested in the issue, do I increase the timeout period or do I need to look for a...

Improve `fromTemplate.test.ts` to avoid intermittent error on CI

Is there any particular reason though because of which the template generation is happening so slowly only for MacOS?

feat: add the flag for disabling optimizations

Hey folks, I apologize for the delay as I've been busy over the past week or two. I will address all the comments made by the maintainers on this PR...

feat: add the flag for disabling optimizations

I have made the changes that were talked about in the discussion. The PR can be reviewed.

feat: add the flag for disabling optimizations

I have tried making the changes as asked, but I am not sure if this is the correct way to implement it. PTAL @KhudaDad414

feat: add the flag for disabling optimizations

Hi maintainers, can you please review the PR? It has been pending for quite a while. cc: @Amzani, @KhudaDad414, @Souvikns, @Shurtu-gal

feat: add the flag for disabling optimizations

/rtm

feat: make the open graph tags dynamic based on the ``base64`` and ``url`` query parameters

Thank you for the review @KhudaDad414. I will add the suggested changes.

feat: make the open graph tags dynamic based on the ``base64`` and ``url`` query parameters

Also, I had a few questions: - Is it okay if I hardcode the popular social media site crawlers as I have done now or is it better if we...

feat: make the open graph tags dynamic based on the ``base64`` and ``url`` query parameters

> Will that work in a Netlify setup? I mentioned an alternative in case it doesn't in #224. Yes, it works. The service is currently hosted on Netlify: https://ogp-studio.netlify.app. >...