browser-ext-github-monaco icon indicating copy to clipboard operation
browser-ext-github-monaco copied to clipboard

Use Monaco editor when editing repo files

Open joaomoreno opened this issue 4 years ago • 2 comments

This is a bigger one!

It would be fantastic to also reuse the Monaco editor when editing files directly in the repo.

joaomoreno avatar Dec 16 '20 10:12 joaomoreno

I was coming to report this exact issue. How interesting that the issue is reported by one of the authors of VSCode. Hey @joaomoreno 👋

@hediet - I directly edit github code pretty frequently, and would be very interested in landing this as a PR.

I've always wondered why GitHub which is now a MS product doesn't use monaco as the default editor (which is also MS owned) 🤷‍♂️

If you have any pointers to point me in the right direction, let me know. I'll take a stab at it anyway.

Thank you for build this great extension.

nojvek avatar Jun 21 '21 17:06 nojvek

I directly edit github code pretty frequently, and would be very interested in landing this as a PR. If you have any pointers to point me in the right direction, let me know. I'll take a stab at it anyway.

Unfortunately, I think this is not that easy and not much of my effort can be reused...

I think as a first exercise, you should try to replace the Github editor (which I think is Ace) with a plain simple HTML TextArea that you have fully under control.

I can help you with replacing this TextArea with the monaco editor.

How interesting that the issue is reported by one of the authors of VSCode

Well, I demo'd this project to the VS Code team in my interview 😉

hediet avatar Jun 21 '21 21:06 hediet