haskell-hedgehog icon indicating copy to clipboard operation
haskell-hedgehog copied to clipboard

Published 20 hours ago • verified publisher icon hedgehogqa

Replace `exceptions` dependency with `safe-exceptions`

Open ocharles opened this issue 3 years ago • 1 comments
trafficstars

By using safe-exceptions we avoid catching asynchronous exceptions, which aren't of any interest to Hedgehog. The current usage of exceptions is problematic, because checkReport calls catchAny, which means it catches asynchronous exceptions. This is a problem for tasty-hedgehog, because it means that Tasty's timeout mechanism can't be used to timeout Hedgehog tests (https://github.com/qfpl/tasty-hedgehog/issues/64, https://github.com/UnkindPartition/tasty/issues/349)

ocharles avatar Sep 10 '22 17:09 ocharles

Great! I'll get these CI problem fixed up and then I'll squash it down to one commit.

ocharles avatar Sep 14 '22 10:09 ocharles

@moodmosaic Ok, all done! I think this is ready to go now.

ocharles avatar Sep 27 '22 09:09 ocharles

Thank you, @ocharles 👍

moodmosaic avatar Oct 04 '22 10:10 moodmosaic

YW!

ocharles avatar Oct 04 '22 10:10 ocharles