day-mode should be extended to editor

[igalic]

Which part of the project should be enhanced?

Currently, when toggling between day and night mode, only the toolbar, and preview are changed. I would like for the actual editor pane to be changed, too.

Is your enhancement request related to a problem? Please describe.

On a bright and sunny day, the dark editor is really really hard to use.

Describe the solution you'd like

The sun and moon toggle the editor from bright to dark, not just the toolbar

Describe alternatives you've considered

alternatively, if people find this offensive to their tastes, i can imagine having different sets of editor styles on the bottom to choose from.

Although i think this solution would be less intuitive and less accessible.

Additional context

I am "old" and I'm only getting older, and my eyes are only gonna get worse.

[DerMolly]

Yes this is the behavior in 1.x. There is also the possibility to switch the editor style.

I'm not sure there are further plans to change this behavior for 2.0.

Also I thought there was already an issue about supporting multiple themes for codemirror (that's the lib that does most of the editor part in HedgeDoc) in the react-client repo, but apparently I'm mistaken.

[igalic]

that is really hard to see or hit, on mobile so perhaps just following, by default, the OS / browser's dark / bright preference would be preferable from a usability standpoint.

aaaaand, given that this repo is now only the backend, maybe it would make sense to migrate this issue to https://github.com/hedgedoc/react-client/issues

[davidmehren]

Moved to the frontend repo so the frontend team can discuss possible changes in 2.0

[mrdrogdrog]

If you haven't changed the app theme with the toolbar toggle, then the app(in 2.0) should already follow the browser dark/light mode. Right now the editor theme is detached from the global theme.

IMHO: Of course we can add a linking and it sounds like a good idea, so we should do that. But I don't know if it's a good idea to link them by default.

[ErikMichelson]

alternatively, if people find this offensive to their tastes, i can imagine having different sets of editor styles on the bottom to choose from.

Actually version 2.0 already features multiple theme support. In the editor preferences (wrench icon in toolbar) one can change the editor theme from light to dark and vice-versa. But in fact that's just a toggle for the underlying codemirror theme, this could very easily be extended for more themes.

Besides that I'm with @mrdrogdrog that the app-dark-mode should not be coupled with the editor by default, but one could opt-in for such a feature.