atom-vue icon indicating copy to clipboard operation
atom-vue copied to clipboard

Not using tree sitter grammars

Open dflock opened this issue 6 years ago • 4 comments
trafficstars

The current atom-vue isn't a tree-sitter grammar and doesn't use tree sitter grammars for JavaScript <script> parts either.

dflock avatar Aug 14 '19 03:08 dflock

@dflock Thanks for the proposal. We shall work on it.

aidistan avatar Sep 23 '19 02:09 aidistan

Is this why object keys changed color recently? (Maybe when Atom started using tree sitter stuff?) Right now, my object keys are all green, as if they were a string, where they used to be red.

Screenshot from 2019-09-23 11-20-25

foundryspatial-duncan avatar Sep 23 '19 18:09 foundryspatial-duncan

@foundryspatial-duncan Yes, it is. Since Atom used tree-sitter as the default parser from 1.32.

aidistan avatar Sep 24 '19 00:09 aidistan

I've added a Tree-Sitter grammar on my fork of this library, which relies on the tree-sitter-vue parser that was created recently.

If people would like to check it out and maybe even fill in some of the gaps, I would be grateful. My grammar is pretty minimalistic, and I've only tested it on the Dracula theme.

I still need to add syntax highlighting for the '

jonboiser avatar Jan 07 '20 22:01 jonboiser

@dflock as this package is now in mostly maintenance mode, I'm going to venture to suggest this feature may not be implemented for the time being. It's of course very appreciated that you reached out with the feature request, but I'm not aware of any efforts being made to additionally offer a Tree-Sitter grammar. That is unless @jonboiser would want to draft a PR with their forked changes back here and get those merged in, which would be fantastic!

Otherwise, while appreciated, I'll go ahead and close this issue for now, as this feature does not seem to be planned.

confused-Techie avatar Aug 03 '23 02:08 confused-Techie